Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding code for release v0.5.0 (beta-3) of CV-CUDA #127

Merged
merged 1 commit into from
Dec 14, 2023
Merged

feat: adding code for release v0.5.0 (beta-3) of CV-CUDA #127

merged 1 commit into from
Dec 14, 2023

Conversation

milesp-nvidia
Copy link
Member

No description provided.

@milesp-nvidia milesp-nvidia force-pushed the feat/milesp/release_v0.5.0-beta3 branch 2 times, most recently from 7deebcd to e274d94 Compare December 14, 2023 16:20
@milesp-nvidia milesp-nvidia force-pushed the feat/milesp/release_v0.5.0-beta3 branch from e274d94 to 0a26f9f Compare December 14, 2023 19:39
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 14, 2023
View reviewed changes
src/cvcuda/include/cvcuda/Types.h

// @brief Defines how a vector normalization should occur
typedef enum
{

Check notice

Code scanning / CodeQL

Irregular enum initialization

In an enumerator list, the = construct should not be used to explicitly initialize members other than the first, unless all items are explicitly initialized.
src/cvcuda/include/cvcuda/Workspace.hpp
return *this;
}

UniqueWorkspace(Workspace workspace, Deleter del = {})

Check notice

Code scanning / CodeQL

Large object passed by value

This parameter of type [Workspace](1) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](2) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](3) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](4) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](5) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](6) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](7) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](8) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](9) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](10) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](11) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](12) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](13) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](14) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](15) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](16) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](17) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](18) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](19) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](20) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](21) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](22) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](23) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](24) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](25) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](26) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](27) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](28) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](29) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](30) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](31) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](32) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](33) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](34) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](35) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](36) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](37) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](38) is 96 bytes - consider passing a const pointer/reference instead. This parameter of type [Workspace](39) is 96 bytes - consider passing a const pointer/reference instead. This param
dlesage-nvidia
dlesage-nvidia approved these changes Dec 14, 2023
View reviewed changes
Copy link
Contributor

@dlesage-nvidia dlesage-nvidia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@milesp-nvidia milesp-nvidia merged commit fc9e7bb into main Dec 14, 2023
@milesp-nvidia milesp-nvidia mentioned this pull request Dec 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pmikolajczyk pmikolajczyk pmikolajczyk approved these changes

@dlesage-nvidia dlesage-nvidia dlesage-nvidia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@milesp-nvidia @pmikolajczyk @dlesage-nvidia