Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Bevy main, in preparation for 0.6 #14

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

rezural
Copy link

@rezural rezural commented Dec 6, 2021

This is a chase the errors upgrade to latest bevy main.

I am not sure if there are architectural changes needed, or subtle errors introduced, as this is the first time looking at this crate.

The examples work, so that is nice.

Thanks

@TheNeikos
Copy link
Contributor

Would you be okay if I were to leave this open until 0.6 gets released?

@rezural
Copy link
Author

rezural commented Dec 13, 2021

Of course, this is just the result of me playing around with bevy main. There's definately some more changes to be made:

  • docs
  • usages of AppBuilder in examples (IIRC)

@Munksgaard
Copy link

Munksgaard commented Jan 9, 2022

0.6 has been released! 🎉

@jamescarterbell
Copy link

Changes look good, would love to see this get merged!

@rezural
Copy link
Author

rezural commented Jan 16, 2022

I have added 3 commits, that update the README, method documentation, and the src/client.rs, which was causing an error on latest main (not 100% sure this is needed for 0.6).

@rezural
Copy link
Author

rezural commented Jan 16, 2022

I have updated the dependency to bevy 0.6, and also rebased onto main.

Should be good to go.

@duck-rh
Copy link

duck-rh commented Jan 19, 2022

@rezural thanls a lot for your work, it works nicely.
Could you update the Bevy Version Compatibility in the README.MD too?

@duck-rh
Copy link

duck-rh commented Feb 28, 2022

Quack,

@TheNeikos is there any remaining blocker?
I've tested this patch on my project and it works nicely.

\_o<

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants