fix race

Signed-off-by: Cabinfever_B <[email protected]>
CabinfeverB · Nov 8, 2023 · 5fd2e64 · 5fd2e64
1 parent bab5c8a
commit 5fd2e64
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/pkg/ratelimit/limiter.go b/pkg/ratelimit/limiter.go
@@ -173,10 +173,9 @@ func (l *limiter) updateConcurrencyConfig(limit uint64) UpdateStatus {
 				return ConcurrencyChanged
 			}
 			return ConcurrencyNoChange
-		} else {
-			l.concurrency.setLimit(limit)
-			return ConcurrencyChanged
 		}
+		l.concurrency.setLimit(limit)
+		return ConcurrencyChanged
 	}
 	l.concurrency = newConcurrencyLimiter(limit)
 	return ConcurrencyChanged

diff --git a/pkg/ratelimit/limiter_test.go b/pkg/ratelimit/limiter_test.go
@@ -27,17 +27,22 @@ import (
 )
 
 type releaseUtil struct {
+	mu    sync.Mutex
 	dones []DoneFunc
 }
 
 func (r *releaseUtil) release() {
+	r.mu.Lock()
+	defer r.mu.Unlock()
 	if len(r.dones) > 0 {
 		r.dones[0]()
 		r.dones = r.dones[1:]
 	}
 }
 
 func (r *releaseUtil) append(d DoneFunc) {
+	r.mu.Lock()
+	defer r.mu.Unlock()
 	r.dones = append(r.dones, d)
 }