Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bombe 0.5.0 #13

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open

Bombe 0.5.0 #13

wants to merge 28 commits into from

Conversation

jamierocks
Copy link
Member

@jamierocks jamierocks commented Jan 2, 2021

TODO for release

  • IntelliJ migration map
  • Update README

@codecov
Copy link

codecov bot commented Jan 2, 2021

Codecov Report

Attention: Patch coverage is 48.83721% with 44 lines in your changes missing coverage. Please review.

Project coverage is 28.55%. Comparing base (8f1f261) to head (446e809).
Report is 12 commits behind head on master.

Files Patch % Lines
...ev/bombe/jar/asm/JarEntryRemappingTransformer.java 37.50% 9 Missing and 1 partial ⚠️
...adixdev/bombe/provider/CompositeClassProvider.java 0.00% 8 Missing ⚠️
...ev/bombe/type/signature/MethodSignatureReader.java 0.00% 7 Missing ⚠️
.../java/org/cadixdev/bombe/jar/AbstractJarEntry.java 88.57% 1 Missing and 3 partials ⚠️
.../java/org/cadixdev/bombe/jar/JarResourceEntry.java 0.00% 4 Missing ⚠️
...main/java/org/cadixdev/bombe/util/ByteStreams.java 0.00% 4 Missing ⚠️
...ain/java/org/cadixdev/bombe/jar/JarClassEntry.java 75.00% 1 Missing ⚠️
...va/org/cadixdev/bombe/jar/JarEntryTransformer.java 0.00% 1 Missing ⚠️
.../java/org/cadixdev/bombe/jar/JarManifestEntry.java 0.00% 1 Missing ⚠️
...ombe/jar/JarServiceProviderConfigurationEntry.java 0.00% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   26.19%   28.55%   +2.36%     
==========================================
  Files          42       44       +2     
  Lines         672      732      +60     
  Branches       82       94      +12     
==========================================
+ Hits          176      209      +33     
- Misses        478      502      +24     
- Partials       18       21       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

jamierocks and others added 20 commits January 2, 2021 22:27
Thanks to @DemonWav for this implementation :)
Also remove the 'vintage' junit runner, and fix compile issues on
compilers newer than Java 8.
Atlas has been the replacement for a while, everyone should migrate
to it. This is mostly a formality that was missed.
This change documents a feature previously added to Atlas [1], and
introduces support (since the API is still available) to the legacy
Jars utility.

[1] CadixDev/Atlas@bb22f81
This adds multi-release jar handling to the model and
updates the remapping transformer to be aware of that information.
Basic multi-release jar handling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants