Update redstone wire optimizations and fix #581 #583
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2No2Name
reviewed
Nov 11, 2024
| private static boolean ignoreNonWires = false; | ||
|
|
||
| public static int getNeighborBlockSignal(Block wireBlock, RedstoneWireEvaluator evaluator, Level level, BlockPos pos) { | ||
| ignoreWires = true; |
There was a problem hiding this comment.
I am concerned about these static fields, mod compatibility with threading mods will definitely suffer
There was a problem hiding this comment.
I think converting them to a local variable should be possible if I am not misunderstanding the code
There was a problem hiding this comment.
yeah that'd work
2No2Name
approved these changes
Nov 11, 2024
| private static boolean ignoreNonWires = false; | ||
|
|
||
| public static int getNeighborBlockSignal(Block wireBlock, RedstoneWireEvaluator evaluator, Level level, BlockPos pos) { | ||
| ignoreWires = true; |
There was a problem hiding this comment.
I think converting them to a local variable should be possible if I am not misunderstanding the code
|
Rebased onto develop and replaced the static fields with local variables. Thanks for the PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.