Skip to content

Commit

Permalink
remove ensureDirectionsAre mixed assertion that is no longer necessary
Browse files Browse the repository at this point in the history
  • Loading branch information
douira committed Feb 26, 2025
1 parent aebdc10 commit 67411df
Showing 1 changed file with 0 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -386,14 +386,6 @@ public SortType finishRendering() {
return this.sortType;
}

private void ensureDirectionsAreMixed() {
int unassignedQuadCount = this.meshFacingCounts[ModelQuadFacing.UNASSIGNED.ordinal()];

if (unassignedQuadCount == 0) {
throw new IllegalStateException("No unassigned data in mesh");
}
}

private TranslucentData makeNewTranslucentData(CombinedCameraPos cameraPos,
TranslucentData oldData) {
if (this.sortType == SortType.NONE) {
Expand All @@ -408,7 +400,6 @@ private TranslucentData makeNewTranslucentData(CombinedCameraPos cameraPos,
// from this point on we know the estimated sort type requires direction mixing
// (no backface culling) and all vertices are in the UNASSIGNED direction.
if (this.sortType == SortType.STATIC_TOPO) {
ensureDirectionsAreMixed();
var result = StaticTopoData.fromMesh(this.quads, this.sectionPos, this.isSplittingQuads());
if (result != null) {
return result;
Expand All @@ -424,7 +415,6 @@ private TranslucentData makeNewTranslucentData(CombinedCameraPos cameraPos,
}

if (this.sortType == SortType.DYNAMIC) {
ensureDirectionsAreMixed();
try {
return DynamicBSPData.fromMesh(cameraPos, this.quads, this.sectionPos, oldData, this.quadSplittingMode);
} catch (BSPBuildFailureException e) {
Expand Down

0 comments on commit 67411df

Please sign in to comment.