Fix hashmap corruption by using an immutable key object

CaffeineMC · Jan 30, 2025 · db29175 · db29175
1 parent d2f2d74
commit db29175
Showing 1 changed file with 3 additions and 1 deletion.
diff --git a/...affeinemc/mods/sodium/client/render/chunk/translucent_sorting/trigger/GeometryPlanes.java b/...affeinemc/mods/sodium/client/render/chunk/translucent_sorting/trigger/GeometryPlanes.java
@@ -84,7 +84,9 @@ public void addUnalignedPlane(SectionPos sectionPos, Vector3fc normal, float dis
         var normalPlanes = unalignedDistances.get(cleanedNormal);
         if (normalPlanes == null) {
             normalPlanes = new NormalPlanes(sectionPos, new Vector3f(normal));
-            unalignedDistances.put(cleanedNormal, normalPlanes);
+
+            // NOTE: importantly use the cleaned normal here, not the cleanedNormal, which is mutable
+            unalignedDistances.put(normalPlanes.normal, normalPlanes);
         }
         normalPlanes.addPlaneMember(distance);
     }