scummvm: rename if there's version in file name #1303
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In new ScummVM release executable doesn't include version like that was it previous release, i.e.
scummvm.exe
instead ofscummvm-2.9.0.exe
. Because of this renaming added in #1124 results in error during installation (it still ends up successful). I think it's probably better to wrap rename command with condition in case user wants to install older version.Here's installation log without change: