[type:fix] fix empty value not be handled by custom metrics (apache#2323

) Co-authored-by: tomsun28 <[email protected]>
Calvin979 · Jul 21, 2024 · 43afb0b · 43afb0b
1 parent ee9bdf6
commit 43afb0b
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/...src/main/java/org/apache/hertzbeat/warehouse/store/realtime/memory/MemoryDataStorage.java b/...src/main/java/org/apache/hertzbeat/warehouse/store/realtime/memory/MemoryDataStorage.java
@@ -72,10 +72,6 @@ public void saveData(CollectRep.MetricsData metricsData) {
         if (metricsData.getCode() != CollectRep.Code.SUCCESS) {
             return;
         }
-        if (metricsData.getValuesList().isEmpty()) {
-            log.debug("[warehouse memory] memory flush metrics data {} is null, ignore.", metricsData.getId());
-            return;
-        }
         Map<String, CollectRep.MetricsData> metricsDataMap = monitorMetricsDataMap.computeIfAbsent(monitorId, key -> new ConcurrentHashMap<>(METRICS_SIZE));
         metricsDataMap.put(metrics, metricsData);
     }

diff --git a/...e/src/main/java/org/apache/hertzbeat/warehouse/store/realtime/redis/RedisDataStorage.java b/...e/src/main/java/org/apache/hertzbeat/warehouse/store/realtime/redis/RedisDataStorage.java
@@ -79,10 +79,7 @@ public void saveData(CollectRep.MetricsData metricsData) {
         if (metricsData.getCode() != CollectRep.Code.SUCCESS || !isServerAvailable()) {
             return;
         }
-        if (metricsData.getValuesList().isEmpty()) {
-            log.info("[warehouse redis] redis flush metrics data {} - {} is null, ignore.", key, hashKey);
-            return;
-        }
+
         RedisAsyncCommands<String, CollectRep.MetricsData> commands = connection.async();
         commands.select(db);
         commands.hset(key, hashKey, metricsData).thenAccept(response -> {