[Improve](Job)Return directly when the job status does not need to ch…

…ange
CalvinKirs · Feb 14, 2024 · 262cac0 · 262cac0
1 parent 7a2c1b8
commit 262cac0
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/job/base/AbstractJob.java b/fe/fe-core/src/main/java/org/apache/doris/job/base/AbstractJob.java
@@ -244,11 +244,11 @@ public void updateJobStatus(JobStatus newJobStatus) throws JobException {
         if (null == newJobStatus) {
             throw new IllegalArgumentException("jobStatus cannot be null");
         }
-        String errorMsg = String.format("Can't update job %s status to the %s status",
-                jobStatus.name(), newJobStatus.name());
         if (jobStatus == newJobStatus) {
-            throw new IllegalArgumentException(errorMsg);
+            return;
         }
+        String errorMsg = String.format("Can't update job %s status to the %s status",
+                jobStatus.name(), newJobStatus.name());
         if (newJobStatus.equals(JobStatus.RUNNING) && !jobStatus.equals(JobStatus.PAUSED)) {
             throw new IllegalArgumentException(errorMsg);
         }