[Improve](common)Optimize logging performance with LOG.isDebugEnabled()

CalvinKirs · Feb 18, 2024 · 9daf81d · 9daf81d
1 parent d3a22fb
commit 9daf81d
Show file tree

Hide file tree

Showing 384 changed files with 1,335 additions and 2,902 deletions.
diff --git a/fe/be-java-extensions/avro-scanner/src/main/java/org/apache/doris/avro/AvroReader.java b/fe/be-java-extensions/avro-scanner/src/main/java/org/apache/doris/avro/AvroReader.java
@@ -63,9 +63,7 @@ public abstract class AvroReader {
     protected void openSchemaReader() throws IOException {
         InputStream inputStream = new BufferedInputStream(fileSystem.open(path));
         schemaReader = new DataFileStream<>(inputStream, new GenericDatumReader<>());
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("success open avro schema reader.");
-        }
+        LOG.debug("success open avro schema reader.");
     }
 
     protected void openDataReader(AvroFileContext avroFileContext) throws IOException {
@@ -74,9 +72,7 @@ protected void openDataReader(AvroFileContext avroFileContext) throws IOExceptio
         FileSplit fileSplit =
                 new FileSplit(path, avroFileContext.getSplitStartOffset(), avroFileContext.getSplitSize(), job);
         dataReader = new AvroRecordReader<>(job, fileSplit);
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("success open avro data reader.");
-        }
+        LOG.debug("success open avro data reader.");
     }
 
     protected void projectionSchema(JobConf job, AvroFileContext avroFileContext) {
@@ -103,9 +99,7 @@ protected void projectionSchema(JobConf job, AvroFileContext avroFileContext) {
             projectionSchema = avroSchema;
         }
         AvroJob.setInputSchema(job, projectionSchema);
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("projection avro schema is:" + projectionSchema.toString());
-        }
+        LOG.debug("projection avro schema is:" + projectionSchema.toString());
     }
 
 }
diff --git a/...a-extensions/java-common/src/main/java/org/apache/doris/common/jni/utils/JMXJsonUtil.java b/...a-extensions/java-common/src/main/java/org/apache/doris/common/jni/utils/JMXJsonUtil.java
@@ -202,9 +202,7 @@ private static void writeAttribute(JsonGenerator jg, ObjectName oname,
         } catch (RuntimeErrorException e) {
             // RuntimeErrorException happens when an unexpected failure occurs in getAttribute
             // for example https://issues.apache.org/jira/browse/DAEMON-120
-            if (LOG.isDebugEnabled()) {
-                LOG.debug("getting attribute " + attName + " of " + oname + " threw an exception", e);
-            }
+            LOG.debug("getting attribute " + attName + " of " + oname + " threw an exception", e);
             return;
         } catch (AttributeNotFoundException e) {
             //Ignored the attribute was not found, which should never happen because the bean

diff --git a/fe/be-java-extensions/java-udf/src/main/java/org/apache/doris/udf/BaseExecutor.java b/fe/be-java-extensions/java-udf/src/main/java/org/apache/doris/udf/BaseExecutor.java
@@ -138,9 +138,7 @@ public void close() {
                 classLoader.close();
             } catch (IOException e) {
                 // Log and ignore.
-                if (LOG.isDebugEnabled()) {
-                    LOG.debug("Error closing the URLClassloader.", e);
-                }
+                LOG.debug("Error closing the URLClassloader.", e);
             }
         }
         // We are now un-usable (because the class loader has been

diff --git a/fe/be-java-extensions/java-udf/src/main/java/org/apache/doris/udf/UdafExecutor.java b/fe/be-java-extensions/java-udf/src/main/java/org/apache/doris/udf/UdafExecutor.java
@@ -318,9 +318,7 @@ protected void init(TJavaUdfExecutorCtorParams request, String jarPath, Type fun
                         Pair<Boolean, JavaUdfDataType> returnType = UdfUtils.setReturnType(funcRetType,
                                 methods[idx].getReturnType());
                         if (!returnType.first) {
-                            if (LOG.isDebugEnabled()) {
-                                LOG.debug("result function set return parameterTypes has error");
-                            }
+                            LOG.debug("result function set return parameterTypes has error");
                         } else {
                             retType = returnType.second;
                             retClass = methods[idx].getReturnType();
@@ -332,18 +330,14 @@ protected void init(TJavaUdfExecutorCtorParams request, String jarPath, Type fun
                         addIndex = methodAccess.getIndex(UDAF_ADD_FUNCTION);
                         argClass = methods[idx].getParameterTypes();
                         if (argClass.length != parameterTypes.length + 1) {
-                            if (LOG.isDebugEnabled()) {
-                                LOG.debug("add function parameterTypes length not equal " + argClass.length + " "
-                                        + parameterTypes.length + " " + methods[idx].getName());
-                            }
+                            LOG.debug("add function parameterTypes length not equal " + argClass.length + " "
+                                    + parameterTypes.length + " " + methods[idx].getName());
                         }
                         if (!(parameterTypes.length == 0)) {
                             Pair<Boolean, JavaUdfDataType[]> inputType = UdfUtils.setArgTypes(parameterTypes,
                                     argClass, true);
                             if (!inputType.first) {
-                                if (LOG.isDebugEnabled()) {
-                                    LOG.debug("add function set arg parameterTypes has error");
-                                }
+                                LOG.debug("add function set arg parameterTypes has error");
                             } else {
                                 argTypes = inputType.second;
                             }

diff --git a/fe/be-java-extensions/java-udf/src/main/java/org/apache/doris/udf/UdfExecutor.java b/fe/be-java-extensions/java-udf/src/main/java/org/apache/doris/udf/UdfExecutor.java
@@ -142,9 +142,7 @@ protected void init(TJavaUdfExecutorCtorParams request, String jarPath, Type fun
         String className = request.fn.scalar_fn.symbol;
         ArrayList<String> signatures = Lists.newArrayList();
         try {
-            if (LOG.isDebugEnabled()) {
-                LOG.debug("Loading UDF '" + className + "' from " + jarPath);
-            }
+            LOG.debug("Loading UDF '" + className + "' from " + jarPath);
             ClassLoader loader;
             if (jarPath != null) {
                 // Save for cleanup.
@@ -188,9 +186,7 @@ protected void init(TJavaUdfExecutorCtorParams request, String jarPath, Type fun
                         retType = returnType.second;
                     }
                     argTypes = new JavaUdfDataType[0];
-                    if (LOG.isDebugEnabled()) {
-                        LOG.debug("Loaded UDF '" + className + "' from " + jarPath);
-                    }
+                    LOG.debug("Loaded UDF '" + className + "' from " + jarPath);
                     return;
                 }
                 returnType = UdfUtils.setReturnType(funcRetType, m.getReturnType());
@@ -207,9 +203,7 @@ protected void init(TJavaUdfExecutorCtorParams request, String jarPath, Type fun
                 } else {
                     argTypes = inputType.second;
                 }
-                if (LOG.isDebugEnabled()) {
-                    LOG.debug("Loaded UDF '" + className + "' from " + jarPath);
-                }
+                LOG.debug("Loaded UDF '" + className + "' from " + jarPath);
                 retType.setKeyType(keyType);
                 retType.setValueType(valueType);
                 return;

diff --git a/...ava-extensions/paimon-scanner/src/main/java/org/apache/doris/paimon/PaimonJniScanner.java b/...ava-extensions/paimon-scanner/src/main/java/org/apache/doris/paimon/PaimonJniScanner.java
@@ -64,9 +64,7 @@ public class PaimonJniScanner extends JniScanner {
 
     public PaimonJniScanner(int batchSize, Map<String, String> params) {
         this.classLoader = this.getClass().getClassLoader();
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("params:{}", params);
-        }
+        LOG.debug("params:{}", params);
         this.params = params;
         String[] requiredFields = params.get("required_fields").split(",");
         String[] requiredTypes = params.get("columns_types").split("#");
@@ -119,17 +117,13 @@ private int[] getProjected() {
 
     private List<Predicate> getPredicates() {
         List<Predicate> predicates = PaimonScannerUtils.decodeStringToObject(paimonPredicate);
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("predicates:{}", predicates);
-        }
+        LOG.debug("predicates:{}", predicates);
         return predicates;
     }
 
     private Split getSplit() {
         Split split = PaimonScannerUtils.decodeStringToObject(paimonSplit);
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("split:{}", split);
-        }
+        LOG.debug("split:{}", split);
         return split;
     }
 
@@ -207,9 +201,7 @@ private void initTable() {
         }
         this.table = tableExt.getTable();
         paimonAllFieldNames = PaimonScannerUtils.fieldNames(this.table.rowType());
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("paimonAllFieldNames:{}", paimonAllFieldNames);
-        }
+        LOG.debug("paimonAllFieldNames:{}", paimonAllFieldNames);
     }
 
 }
diff --git a/fe/fe-common/src/main/java/org/apache/doris/catalog/PrimitiveType.java b/fe/fe-common/src/main/java/org/apache/doris/catalog/PrimitiveType.java
@@ -1006,3 +1006,4 @@ public int getOlapColumnIndexSize() {
         }
     }
 }
+
diff --git a/fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java b/fe/fe-common/src/main/java/org/apache/doris/catalog/Type.java
@@ -2322,3 +2322,4 @@ public static Type getTypeFromTypeName(String typeName) {
         return typeMap.getOrDefault(typeName, Type.UNSUPPORTED);
     }
 }
+
diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/VariableAnnotation.java b/fe/fe-common/src/main/java/org/apache/doris/common/VariableAnnotation.java
@@ -38,3 +38,4 @@ public String getPrefix() {
         return prefix;
     }
 }
+
diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/io/LimitInputStream.java b/fe/fe-common/src/main/java/org/apache/doris/common/io/LimitInputStream.java
@@ -51,9 +51,7 @@ public LimitInputStream(InputStream in, int limitspeed) throws IOException {
             throw new IOException("InputStream is null");
         }
         speed = limitspeed;
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("LimitinputStream limit speed: {}", speed);
-        }
+        LOG.debug("LimitinputStream limit speed: {}", speed);
         this.in = in;
         bytesReadTotal = 0;
         bstart = false;

diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/io/LimitOutputStream.java b/fe/fe-common/src/main/java/org/apache/doris/common/io/LimitOutputStream.java
@@ -52,9 +52,7 @@ public LimitOutputStream(OutputStream out, int limitspeed)
             throw new IOException("OutputStream is null");
         }
         speed = limitspeed;
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("LimitOutputStream limit speed: {}", speed);
-        }
+        LOG.debug("LimitOutputStream limit speed: {}", speed);
         this.out = out;
         bytesWriteTotal = 0;
         bstart = false;

diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/jmockit/ConstructorReflection.java b/fe/fe-common/src/main/java/org/apache/doris/common/jmockit/ConstructorReflection.java
@@ -158,3 +158,4 @@ public static void makeAccessible(AccessibleObject classMember) {
         }
     }
 }
+
diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/jmockit/FieldReflection.java b/fe/fe-common/src/main/java/org/apache/doris/common/jmockit/FieldReflection.java
@@ -285,3 +285,4 @@ private static boolean isSameType(Class<?> firstType, Class<?> secondType) {
     }
 
 }
+
diff --git a/fe/fe-common/src/main/java/org/apache/doris/common/jmockit/ParameterReflection.java b/fe/fe-common/src/main/java/org/apache/doris/common/jmockit/ParameterReflection.java
@@ -165,3 +165,4 @@ private static boolean isSameType(Class<?> firstType, Class<?> secondType) {
                 || secondType.isPrimitive() && secondType == AutoType.getPrimitiveType(firstType);
     }
 }
+
diff --git a/fe/fe-core/src/main/java/com/aliyun/datalake/metastore/hive2/ProxyMetaStoreClient.java b/fe/fe-core/src/main/java/com/aliyun/datalake/metastore/hive2/ProxyMetaStoreClient.java
@@ -2190,4 +2190,4 @@ public <R> R call(IMetaStoreClient client, ThrowingFunction<IMetaStoreClient, R,
         return FunctionalUtils.call(client, Optional.empty(), allowFailure, consumer, this.readWriteClientType,
                 actionName, parameters);
     }
-}
+}
diff --git a/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/metastore/AWSGlueDecoratorBase.java b/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/metastore/AWSGlueDecoratorBase.java
@@ -1543,3 +1543,4 @@ public UpdateJobFromSourceControlResult updateJobFromSourceControl(UpdateJobFrom
         return null;
     }
 }
+
diff --git a/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/metastore/AWSGlueMetastore.java b/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/metastore/AWSGlueMetastore.java
@@ -130,4 +130,4 @@ List<ColumnStatisticsError> updateTableColumnStatistics(
             String tableName,
             List<ColumnStatistics> columnStatistics
     );
-}
+}
diff --git a/...ore/src/main/java/com/amazonaws/glue/catalog/metastore/AWSGlueMetastoreBaseDecorator.java b/...ore/src/main/java/com/amazonaws/glue/catalog/metastore/AWSGlueMetastoreBaseDecorator.java
@@ -195,4 +195,4 @@ public List<ColumnStatisticsError> updateTableColumnStatistics(String dbName, St
         return awsGlueMetastore.updateTableColumnStatistics(dbName, tableName, columnStatistics);
     }
 
-}
+}
diff --git a/...re/src/main/java/com/amazonaws/glue/catalog/metastore/AWSGlueMetastoreCacheDecorator.java b/...re/src/main/java/com/amazonaws/glue/catalog/metastore/AWSGlueMetastoreCacheDecorator.java
@@ -182,4 +182,4 @@ public int hashCode() {
             return Objects.hash(dbName, tableName);
         }
     }
-}
+}
diff --git a/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/metastore/AWSGlueMetastoreFactory.java b/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/metastore/AWSGlueMetastoreFactory.java
@@ -44,4 +44,4 @@ private boolean isCacheEnabled(Configuration conf) {
         boolean tableCacheEnabled = conf.getBoolean(AWS_GLUE_TABLE_CACHE_ENABLE, false);
         return (databaseCacheEnabled || tableCacheEnabled);
     }
-}
+}
diff --git a/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/metastore/DefaultAWSGlueMetastore.java b/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/metastore/DefaultAWSGlueMetastore.java
@@ -659,4 +659,4 @@ public UpdateColumnStatisticsForTableResult call() throws Exception {
         }
         return columnStatisticsErrors;
     }
-}
+}
diff --git a/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/util/AWSGlueConfig.java b/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/util/AWSGlueConfig.java
@@ -61,4 +61,4 @@ private AWSGlueConfig() {
     public static final String AWS_GLUE_ACCESS_KEY = "aws.glue.access-key";
     public static final String AWS_GLUE_SECRET_KEY = "aws.glue.secret-key";
     public static final String AWS_GLUE_SESSION_TOKEN = "aws.glue.session-token";
-}
+}
diff --git a/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/util/BatchCreatePartitionsHelper.java b/fe/fe-core/src/main/java/com/amazonaws/glue/catalog/util/BatchCreatePartitionsHelper.java
@@ -150,4 +150,4 @@ public List<Partition> getPartitionsFailed() {
     return partitionsFailed;
   }
 
-}
+}
diff --git a/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java b/fe/fe-core/src/main/java/org/apache/doris/alter/MaterializedViewHandler.java
@@ -446,10 +446,8 @@ private RollupJobV2 createMaterializedViewJob(String rawSql, String mvName, Stri
 
             mvJob.addMVIndex(partitionId, mvIndex);
 
-            if (LOG.isDebugEnabled()) {
-                LOG.debug("create materialized view index {} based on index {} in partition {}",
-                        mvIndexId, baseIndexId, partitionId);
-            }
+            LOG.debug("create materialized view index {} based on index {} in partition {}",
+                    mvIndexId, baseIndexId, partitionId);
         } // end for partitions
 
         LOG.info("finished to create materialized view job: {}", mvJob.getJobId());
@@ -610,9 +608,7 @@ private List<Column> checkAndPrepareMaterializedView(CreateMaterializedViewStmt
                 column.setUniqueId(Column.COLUMN_UNIQUE_ID_INIT_VALUE);
             });
         }
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("lightSchemaChange:{}, newMVColumns:{}", olapTable.getEnableLightSchemaChange(), newMVColumns);
-        }
+        LOG.debug("lightSchemaChange:{}, newMVColumns:{}", olapTable.getEnableLightSchemaChange(), newMVColumns);
         return newMVColumns;
     }
 
@@ -856,11 +852,8 @@ public List<Column> checkAndPrepareMaterializedView(AddRollupClause addRollupCla
                 column.setUniqueId(Column.COLUMN_UNIQUE_ID_INIT_VALUE);
             });
         }
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("lightSchemaChange:{}, rollupSchema:{}, baseSchema:{}",
-                    olapTable.getEnableLightSchemaChange(), rollupSchema,
-                    olapTable.getSchemaByIndexId(baseIndexId, true));
-        }
+        LOG.debug("lightSchemaChange:{}, rollupSchema:{}, baseSchema:{}",
+                olapTable.getEnableLightSchemaChange(), rollupSchema, olapTable.getSchemaByIndexId(baseIndexId, true));
         return rollupSchema;
     }
 
@@ -1133,11 +1126,9 @@ private void runAlterJobWithConcurrencyLimit(RollupJobV2 rollupJobV2) {
                 tableRunningJobSet.add(jobId);
                 shouldJobRun = true;
             } else {
-                if (LOG.isDebugEnabled()) {
-                    LOG.debug("number of running alter job {} in table {} exceed limit {}. job {} is suspended",
-                            tableRunningJobSet.size(), rollupJobV2.getTableId(),
-                            Config.max_running_rollup_job_num_per_table, rollupJobV2.getJobId());
-                }
+                LOG.debug("number of running alter job {} in table {} exceed limit {}. job {} is suspended",
+                        tableRunningJobSet.size(), rollupJobV2.getTableId(),
+                        Config.max_running_rollup_job_num_per_table, rollupJobV2.getJobId());
                 shouldJobRun = false;
             }
         }

diff --git a/fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java b/fe/fe-core/src/main/java/org/apache/doris/alter/RollupJobV2.java
@@ -608,10 +608,8 @@ private void onFinished(OlapTable tbl) {
 
         tbl.getIndexMetaByIndexId(rollupIndexId).setMaxColUniqueId(maxColUniqueId);
 
-        if (LOG.isDebugEnabled()) {
-            LOG.debug("rollupIndexId:{}, maxColUniqueId:{}, indexIdToSchema:{}", rollupIndexId, maxColUniqueId,
-                    tbl.getIndexIdToSchema(true));
-        }
+        LOG.debug("rollupIndexId:{}, maxColUniqueId:{}, indexIdToSchema:{}", rollupIndexId, maxColUniqueId,
+                tbl.getIndexIdToSchema(true));
         tbl.rebuildFullSchema();
     }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1006,3 +1006,4 @@ public int getOlapColumnIndexSize() {
		}
		}
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -2322,3 +2322,4 @@ public static Type getTypeFromTypeName(String typeName) {
		return typeMap.getOrDefault(typeName, Type.UNSUPPORTED);
		}
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -38,3 +38,4 @@ public String getPrefix() {
		return prefix;
		}
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -158,3 +158,4 @@ public static void makeAccessible(AccessibleObject classMember) {
		}
		}
		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -285,3 +285,4 @@ private static boolean isSameType(Class<?> firstType, Class<?> secondType) {
		}

		}
Original file line number	Diff line number	Diff line change
Expand Up		@@ -165,3 +165,4 @@ private static boolean isSameType(Class<?> firstType, Class<?> secondType) {
		\|\| secondType.isPrimitive() && secondType == AutoType.getPrimitiveType(firstType);
		}
		}
-Original file line number
+Diff line change
@@ Expand Up @@
             return FunctionalUtils.call(client, Optional.empty(), allowFailure, consumer, this.readWriteClientType,
                     actionName, parameters);
         }
-    }
+    }
Original file line number	Diff line number	Diff line change
Expand Up		@@ -1543,3 +1543,4 @@ public UpdateJobFromSourceControlResult updateJobFromSourceControl(UpdateJobFrom
		return null;
		}
		}