[improvement](profile) do not remove value 0 counter (apache#24487)

do not remove value 0 counter
CalvinKirs · Sep 18, 2023 · b9f1ac1 · b9f1ac1
1 parent 1d1eeae
commit b9f1ac1
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 4 deletions.
diff --git a/fe/fe-core/src/main/java/org/apache/doris/common/util/Counter.java b/fe/fe-core/src/main/java/org/apache/doris/common/util/Counter.java
@@ -23,6 +23,7 @@
 public class Counter {
     private volatile long value;
     private volatile int type;
+    private volatile boolean remove = false;
 
     public long getValue() {
         return value;
@@ -68,4 +69,12 @@ public boolean isTimeType() {
         TUnit ttype = TUnit.findByValue(type);
         return ttype == TUnit.TIME_MS || ttype == TUnit.TIME_NS || ttype == TUnit.TIME_S;
     }
+
+    public void setCanRemove() {
+        this.remove = true;
+    }
+
+    public boolean isRemove() {
+        return this.remove;
+    }
 }
diff --git a/fe/fe-core/src/main/java/org/apache/doris/common/util/RuntimeProfile.java b/fe/fe-core/src/main/java/org/apache/doris/common/util/RuntimeProfile.java
@@ -399,7 +399,7 @@ private static void mergeProfileCounter(RuntimeProfile src, String counterName,
 
             mergeProfileCounter(src, childCounterName, rhs);
             mergeCounter(src, childCounterName, counter, rhsCounter);
-            removeZeroeCounter(childCounterSet, childCounterName, counter);
+            removeCounter(childCounterSet, childCounterName, counter);
 
         }
     }
@@ -423,8 +423,8 @@ private static void mergeProfileInfoStr(RuntimeProfile src, LinkedList<RuntimePr
         }
     }
 
-    private static void removeZeroeCounter(Set<String> childCounterSet, String childCounterName, Counter counter) {
-        if (counter.getValue() == 0) {
+    private static void removeCounter(Set<String> childCounterSet, String childCounterName, Counter counter) {
+        if (counter.isRemove()) {
             childCounterSet.remove(childCounterName);
         }
     }
@@ -476,7 +476,7 @@ private static void mergeCounter(RuntimeProfile src, String counterName, Counter
                         + MIN_TIME_PRE + printCounter(minCounter.getValue(), minCounter.getType()) + " ]";
                 src.infoStrings.put(counterName, infoString);
             }
-            counter.setValue(0); // value 0 will remove in removeZeroeCounter
+            counter.setCanRemove(); // value will remove in removeCounter
         } else {
             if (rhsCounter.size() == 0) {
                 return;