-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganise main mod #217
Reorganise main mod #217
Conversation
5359fe0
to
169cbe8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jwallwork23 , this is a simple improvement and helps with maintainability.
My only concern is relating to the recently changed int32
types which have now been converted to ftorch_int
(which defaults to int32
but could in theory change).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jwallwork23 , LGTM now 🚀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I am in agreement that this is a good idea and happy.
Only suggestion would be to perhaps make the section headers even more obvious e.g.
! =============================================
! = --- Derived types and enums =
! =============================================
To stand out when people are browsing the source.
Addressed in c2e9c1b. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Go for it.
To follow #76.
This PR reorganises the main FTorch module to group things more logically:
This PR also drops unnecessary imports and makes it so that the
device_index
argument can be passed as a Fortraninteger
rather than ac_int
.