Skip to content

Commit

Permalink
Do not run rails >= 7 on ruby < 3
Browse files Browse the repository at this point in the history
  • Loading branch information
coorasse committed May 23, 2024
1 parent 1c50bb6 commit 906397d
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 4 deletions.
6 changes: 6 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,12 @@ jobs:
exclude:
- gemfile: 'gemfiles/activerecord_5.2.2.gemfile'
ruby: '3.0' # rails 5.2 can't run on ruby 3.0
- gemfile: 'gemfiles/activerecord_7.0.0.gemfile'
ruby: '2.7'
- gemfile: 'gemfiles/activerecord_7.1.0.gemfile'
ruby: '2.7'
- gemfile: 'gemfiles/activerecord_main.gemfile'
ruby: '2.7'
- gemfile: 'gemfiles/activerecord_6.1.0.gemfile'
ruby: 'jruby' # this *should* work. it seems like there's an issue with rails 6 on jruby.
- gemfile: 'gemfiles/activerecord_main.gemfile'
Expand Down
4 changes: 2 additions & 2 deletions Appraisals
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ appraise 'activerecord_7.1.0' do

platforms :ruby, :mswin, :mingw do
gem 'pg', '~> 1.5.6'
gem 'sqlite3', '~> 2.0.1'
gem 'sqlite3', '~> 1.7.3'
end
end

Expand All @@ -98,6 +98,6 @@ appraise 'activerecord_main' do

platforms :ruby, :mswin, :mingw do
gem 'pg', '~> 1.5.6'
gem 'sqlite3', '~> 2.0.1'
gem 'sqlite3', '~> 1.7.3'
end
end
2 changes: 1 addition & 1 deletion gemfiles/activerecord_7.1.0.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ end

platforms :ruby, :mswin, :mingw do
gem "pg", "~> 1.5.6"
gem "sqlite3", "~> 2.0.1"
gem "sqlite3", "~> 1.7.3"
end

gemspec path: "../"
2 changes: 1 addition & 1 deletion gemfiles/activerecord_main.gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ end

platforms :ruby, :mswin, :mingw do
gem "pg", "~> 1.5.6"
gem "sqlite3", "~> 2.0.1"
gem "sqlite3", "~> 1.7.3"
end

gemspec path: "../"

0 comments on commit 906397d

Please sign in to comment.