New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: rule_spec should honor DB setting #847

Merged

coorasse merged 1 commit into CanCanCommunity:develop from evendis:pg_tests

May 23, 2024

Contributor

tardate commented Apr 30, 2024

I noticed when running db-specific tests e.g.

DB='postgres' bundle exec appraisal activerecord_6.1.0 rake

that spec/cancan/rule_spec.rb could fail if sqlite not available, because it was ignoring the DB context and always/only running with sqlite.

This is just a quick fix to ensure that spec/cancan/rule_spec.rb runs like all other tests with the specific DB selected.


          Fix: rule_spec should honor DB setting

fb52652

coorasse approved these changes

View reviewed changes

Member

coorasse left a comment

Thank you!

coorasse merged commit ac7c686 into CanCanCommunity:develop

16 of 24 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet