builtins/array: clarify sort perf unspecness

CanadaHonk · Jun 7, 2024 · 592cabd · 592cabd
1 parent c7d8775
commit 592cabd
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 3 deletions.
diff --git a/compiler/builtins/array.ts b/compiler/builtins/array.ts
@@ -388,9 +388,12 @@ export const __Array_prototype_sort = (_this: any[], callbackFn: any) => {
         else {
           // 4. If comparefn is not undefined, then
           // a. Let v be ? ToNumber(? Call(comparefn, undefined, « x, y »)).
+          // perf: unneeded as we just check >= 0
+          // v = Number(callbackFn(x, y));
           v = callbackFn(x, y);
 
           // b. If v is NaN, return +0𝔽.
+          // perf: unneeded as we just check >= 0
           // if (Number.isNaN(v)) v = 0;
 
           // c. Return v.

diff --git a/package.json b/package.json
@@ -1,7 +1,7 @@
 {
   "name": "porffor",
   "description": "a basic experimental wip aot optimizing js -> wasm engine/compiler/runtime in js",
-  "version": "0.18.8+024a81666",
+  "version": "0.18.10+c0227b1a9",
   "author": "CanadaHonk",
   "license": "MIT",
   "scripts": {},

diff --git a/runner/index.js b/runner/index.js
@@ -1,6 +1,6 @@
 #!/usr/bin/env node
 import fs from 'node:fs';
-globalThis.version = '0.18.8+024a81666';
+globalThis.version = '0.18.10+c0227b1a9';
 
 // deno compat
 if (typeof process === 'undefined' && typeof Deno !== 'undefined') {

diff --git a/test262/history.json b/test262/history.json