Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bufferSizeMs parameter to recorder interface #7

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ebraraktas
Copy link

This PR allows us to resolve this issue. It adds bufferSizeMs parameter to Android and iOS implementation. Hence, one can record to a stream with chunks having specific size.

@Larpoux
Copy link
Contributor

Larpoux commented Mar 4, 2024

Hi @ebraraktas ,

Thank you very much for your contribution.
I am really impressed by what you did. Coding inside flutter_sound_core is not easy because the library is not under pub.dev.
Congratulations.

Actually I am integrating your code inside the last flutter_sound version.
I have something wrong on Android : it seems that the end of the last buffer is not sent.
Maybe a problem inside writeData(). Or perhaps I did not report correctly your code inside flutterSound.
writeData() is hard to read. Is it possible that you look on it ?

Here is my FlautoRecorderEngine.java
FlautoRecorderEngine.java.txt

(its a .txt because github does not want to include a .java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENH]: Specify chunk size with recorder
3 participants