Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch to github mirrors for cloning #220

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

Ayman161803
Copy link
Contributor

Related Issue: #35

This following PR replaces gerrit with github when extensions and skins are cloned

Areas of discussion

A github mirror for SemanticDrilldown extension was not found on wikimedia's official github account. However, an alternative was found here . The same can replace current SemanticDrillDown gerrit if approved.

Changes made

Dockerfile gets built successfully after replacing gerrit with github mirrors

image

@Ayman161803
Copy link
Contributor Author

cc @jeffw16 @yaronkoren

@jeffw16
Copy link
Member

jeffw16 commented Mar 8, 2023

@Ayman161803 thanks for this commit. Successful compilation of the Dockerfile does not necessarily indicate the extensions are all usable. @yaronkoren do you have any good ideas on how to test these 100+ extensions still work as expected?

@yaronkoren
Copy link
Member

Looks good. I would think just installing Canasta with this Dockerfile, and then doing an "ls -R" within the extensions/ directory would basically do the trick - plus enabling a handful of the extensions to see if they actually work. Presumably, if the same change is done for all of these extensions, then testing a few of them should lead to fairly high confidence that the rest are working as well.

@jeffw16 jeffw16 changed the base branch from master to release/1.3.1 March 21, 2023 22:41
@jeffw16 jeffw16 mentioned this pull request Mar 21, 2023
@jeffw16 jeffw16 merged commit 0f13fb3 into CanastaWiki:release/1.3.1 Apr 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants