Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wren-ui): Create Regenerated Response API & Add Regenerated Information in Thread Detail UI #527

Merged
merged 14 commits into from
Jul 19, 2024

Conversation

andreashimin
Copy link
Contributor

Description

API

  • Add createRegeneratedThreadResponse API
  • Request Structure
    input CreateThreadResponseCorrectionInput {
     id: Int!
     stepIndex: Int!
     type: ReferenceType!
     reference: String!
     correction: String!
    }
    
    input CreateRegeneratedThreadResponseInput {
     responseId: Int!
     corrections: [CreateThreadResponseCorrectionInput!]!
    }
  • Response structure refer to Create Thread Response
    • ps. client need to fetch Thread Response after Create Adjustment Response.
  • Provide adjustment content in Thread & Thread response API
    type ThreadResponse {
      ...
      question
      corrections: [{
        id
        type
        correction
      }]
    }

UI

  • Check thread response type if it is an regenerated response.
  • Change thread detail original question block to regenerated information.

UI Screenshot

image

Copy link
Contributor

@fredalai fredalai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for FE

Copy link
Contributor

@onlyjackfrost onlyjackfrost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beside NIT, others LGTM

@andreashimin andreashimin merged commit 76d5734 into epic/feedback-loop Jul 19, 2024
2 checks passed
@andreashimin andreashimin deleted the feature/regeneration branch July 19, 2024 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants