Skip to content

Commit

Permalink
test(mssql): add non ascii column case (#912)
Browse files Browse the repository at this point in the history
  • Loading branch information
grieve54706 authored and goldmedal committed Nov 25, 2024
1 parent f8abe9c commit 3741033
Showing 1 changed file with 18 additions and 0 deletions.
18 changes: 18 additions & 0 deletions ibis-server/tests/routers/v2/connector/test_mssql.py
Original file line number Diff line number Diff line change
Expand Up @@ -274,6 +274,24 @@ def test_query_with_timezone(manifest_str, mssql: SqlServerContainer):
"test_null_time": "datetime64[ns]",
}

@pytest.mark.skip(
reason="Ibis use non-nvarchar sql to get schema, it will get question mark. Wait https://github.com/ibis-project/ibis/pull/10490"
)
def test_query_non_ascii_column(manifest_str, mssql: SqlServerContainer):
connection_info = _to_connection_info(mssql)
response = client.post(
url=f"{base_url}/query",
params={"limit": 1},
json={
"connectionInfo": connection_info,
"manifestStr": manifest_str,
"sql": 'SELECT 1 AS "калона"',
},
)
assert response.status_code == 200
result = response.json()
assert result["columns"] == ["калона"]

def test_query_timestamp_literal(manifest_str, mssql: SqlServerContainer):
connection_info = _to_connection_info(mssql)
response = client.post(
Expand Down

0 comments on commit 3741033

Please sign in to comment.