Add sqllogictest for modeling-rs end-to-end test #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 tasks
goldmedal
commented
Jun 7, 2024
| } | ||
| } | ||
|
|
||
| pub async fn register_ecommerce_table(test_ctx: &TestContext) { |
There was a problem hiding this comment.
I created and registered the ecommerce case here.
goldmedal
commented
Jun 7, 2024
Comment on lines
+159
to
+162
| ctx.state().with_analyzer_rules(vec![ | ||
| Arc::new(ModelAnalyzeRule::new(Arc::clone(&analyzed_mdl))), | ||
| Arc::new(ModelGenerationRule::new(Arc::clone(&analyzed_mdl))), | ||
| ]); |
There was a problem hiding this comment.
I registered the wren analysis rule here.
goldmedal
commented
Jun 7, 2024
| @@ -0,0 +1,2 @@ | |||
| statement ok | |||
| SELECT * from orders | |||
There was a problem hiding this comment.
This test should be SELECT * from wrenai.default.orders actually.
There is an issue about analyzing a qualified table name. I'll address this in next PR.
goldmedal
force-pushed
the
modeling-rs/feature/sqllogictest-e2e
branch
from
12d7d28
to
86be1cf
Compare
grieve54706
reviewed
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Basically, I copied the sqllogictest in DataFusion as our testing framework. Just remove the postgres test and the test cases.
The e2e test uses DataFusion as the query runner. So I also registered the MDL dataset before running tests.
You can run this e2e test by the command
Follow-up issues