Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate API of ibis #624

Merged
merged 2 commits into from
Jun 21, 2024
Merged

Integrate API of ibis #624

merged 2 commits into from
Jun 21, 2024

Conversation

grieve54706
Copy link
Contributor

Make data source APIs be one API. Because they are not much different.

Add isort into the linter list for sorting the import order.

Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @grieve54706 -- Overall LGTM.

@goldmedal goldmedal merged commit 5fe82bc into main Jun 21, 2024
1 check passed
@goldmedal goldmedal deleted the refactor/ibis/router branch June 21, 2024 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants