Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): Fix tpch query and refactor the analyzing rules #784

Merged
merged 12 commits into from
Sep 9, 2024

Conversation

goldmedal
Copy link
Contributor

Description

  • Fix to analyze the join subquery (tpch q20)
  • Fix to analyze the aggregation
  • refactor the analysis rules

@goldmedal goldmedal changed the title bugfix(core): Fix tpch query and refactor the analyzing rules fix(core): Fix tpch query and refactor the analyzing rules Sep 9, 2024
@goldmedal goldmedal marked this pull request as ready for review September 9, 2024 06:34
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @goldmedal.

@grieve54706 grieve54706 merged commit 96048f5 into Canner:main Sep 9, 2024
12 checks passed
@goldmedal goldmedal deleted the bugfix/fix-tpch-join branch September 9, 2024 07:52
grieve54706 pushed a commit that referenced this pull request Dec 13, 2024
* fix join subquery

* fix aggregate

* enable some test

* fix aggregate

* split model_analyze to a file

* remove unused code

* remove unused code

* add empty end line

* remove unused comment

* cargo fmt

* clippy

* cargo fmt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants