Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): bump DataFusion to 42.0.0 #796

Merged
merged 6 commits into from
Sep 24, 2024
Merged

feat(core): bump DataFusion to 42.0.0 #796

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4c43b6e
upgrade to 42.0.0
goldmedal Sep 19, 2024
6cc3748
disable the fail tests
goldmedal Sep 19, 2024
637150d
enable the test case
goldmedal Sep 19, 2024
6770fad
cargo fmt
goldmedal Sep 19, 2024
14b3416
fix the python tests
goldmedal Sep 19, 2024
6760d5e
fix ibis test
goldmedal Sep 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1,302 changes: 636 additions & 666 deletions ibis-server/poetry.lock
View file
Open in desktop

Large diffs are not rendered by default.

12 changes: 6 additions & 6 deletions ibis-server/tests/routers/v3/connector/test_postgres.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,14 +105,14 @@ def test_query(postgres: PostgresContainer):
assert len(result["columns"]) == len(manifest["models"][0]["columns"])
assert len(result["data"]) == 1
assert result["data"][0] == [
1,
"2024-01-01 23:59:59.000000",
"2024-01-01 23:59:59.000000 UTC",
"1_370",
370,
1,
"1996-01-02",
"O",
"172799.49",
"1996-01-02",
"1_370",
"2024-01-01 23:59:59.000000",
"2024-01-01 23:59:59.000000 UTC",
]
Comment on lines 107 to 116
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The column order is changed. Is it a right thing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Expected. Now we will generate the sql with wildcard character, the ordering would be different.

assert result["dtypes"] == {
"orderkey": "int32",
Expand Down Expand Up @@ -140,7 +140,7 @@ def test_query_with_connection_url(postgres: PostgresContainer):
result = response.json()
assert len(result["columns"]) == len(manifest["models"][0]["columns"])
assert len(result["data"]) == 1
assert result["data"][0][0] == 1
assert result["data"][0][0] == "2024-01-01 23:59:59.000000"
assert result["dtypes"] is not None


Expand Down
Loading
Loading