Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(metadata): avoid using schema as a field name #878

Merged
merged 1 commit into from
Nov 4, 2024
Merged

chore(metadata): avoid using schema as a field name #878

merged 1 commit into from
Nov 4, 2024

Conversation

grieve54706
Copy link
Contributor

Pydantic performs a check on all subclasses of BaseModel to identify any overlapping field names with the base BaseModel class. It then generates a warning to discourage the use of identical field names to mitigate shadowing issues.

.venv/lib/python3.11/site-packages/pydantic/_internal/_fields.py:172
 .../wren-engine/ibis-server/.venv/lib/python3.11/site-packages/pydantic/_internal/_fields.py:172: UserWarning: Field name "schema" in "TableProperties" shadows an attribute in parent "BaseModel"
    warnings.warn(

-- Docs: https://docs.pytest.org/en/stable/how-to/capture-warnings.html

@github-actions github-actions bot added bigquery ibis trino python Pull requests that update Python code labels Nov 1, 2024
@grieve54706 grieve54706 force-pushed the chore/adjust-field-name branch from 6258c5a to 6f9e282 Compare November 1, 2024 06:26
@grieve54706 grieve54706 changed the title chore: avoid using schema as a field name chore(metadata): avoid using schema as a field name Nov 1, 2024
@goldmedal goldmedal merged commit e521453 into main Nov 4, 2024
9 checks passed
@goldmedal goldmedal deleted the chore/adjust-field-name branch November 4, 2024 02:06
gagan-bhullar-tech pushed a commit to gagan-bhullar-tech/wren-engine that referenced this pull request Nov 6, 2024
@grieve54706 @gagan-bhullar-tech
chore(metadata): avoid using schema as a field name (Canner#878)
46be0e0
@grieve54706 grieve54706 added this to the 0.11.3 milestone Nov 12, 2024
grieve54706 added a commit that referenced this pull request Dec 13, 2024
@grieve54706 @goldmedal
chore(metadata): avoid using schema as a field name (#878)
5c13d9b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goldmedal goldmedal goldmedal approved these changes

@onlyjackfrost onlyjackfrost Awaiting requested review from onlyjackfrost

Assignees
No one assigned
Labels
bigquery ibis python Pull requests that update Python code trino
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@grieve54706 @goldmedal