Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(ibis): append Trino test to standard tests #879

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

grieve54706
Copy link
Contributor

@grieve54706 grieve54706 commented Nov 1, 2024

By introducing a delay after the Trino container startup, we resolved the issue #671.
So we can reintegrate Trino tests into the standard tests.

@grieve54706 grieve54706 changed the title ci(ibis): append Trino test to generic test cases ci(ibis): append Trino test to standard tests Nov 1, 2024
Copy link
Contributor

@goldmedal goldmedal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@goldmedal goldmedal merged commit fcd5bfd into main Nov 4, 2024
11 checks passed
@goldmedal goldmedal deleted the chore/make-trino-test-normally branch November 4, 2024 02:09
gagan-bhullar-tech pushed a commit to gagan-bhullar-tech/wren-engine that referenced this pull request Nov 6, 2024
@grieve54706 grieve54706 added this to the 0.11.3 milestone Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants