Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: apache druid datasource #882

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

feat: apache druid datasource #882

wants to merge 8 commits into from

Conversation

gagan-bhullar-tech
Copy link

@gagan-bhullar-tech gagan-bhullar-tech commented Nov 3, 2024 •
edited
Loading

PR closes part of #711

@github-actions github-actions bot added ibis dependencies Pull requests that update a dependency file python Pull requests that update Python code labels Nov 3, 2024
@gagan-bhullar-tech
Copy link
Author

@chilijung there is no test container available for Druid. Can you please let me know how can i add a test.

@chilijung
Copy link
Member

@grieve54706 @goldmedal Please help provide guidance. Thanks

@grieve54706
Copy link
Contributor

grieve54706 commented Nov 4, 2024 •
edited
Loading

Hi @gagan-bhullar-tech, please follow the development to install pre-commit first.

Druid provides the docker image and the python client.
You can use them to insert parquet data and query data.

You can submit a task to create a datasource by HTTP API.
The input source type could be local and the format type be parquet.

@grieve54706
Copy link
Contributor

grieve54706 commented Nov 4, 2024 •
edited
Loading

We are a different repo from Wren-AI. You must use a complete URL instead of #ISSUE-NUMBER.

@gagan-bhullar-tech
Copy link
Author

gagan-bhullar-tech commented Nov 5, 2024 •
edited
Loading

@chilijung @grieve54706 can you please review.

@github-actions github-actions bot added documentation Improvements or additions to documentation core rust Pull requests that update Rust code labels Nov 6, 2024
@gagan-bhullar-tech gagan-bhullar-tech changed the title feat: apache druid datasource connector feat: apache druid datasource Nov 6, 2024
@grieve54706
Copy link
Contributor

Hey @gagan-bhullar-tech, I don't see any test for ibis-server API. Please refer test suite of other data sources.

grieve54706
grieve54706 requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Miss test case for ibis-server API

@gagan-bhullar-tech
Copy link
Author

@grieve54706 this PR is for creating a datasource. I was thinking of creating a separate PR for API.

@grieve54706
Copy link
Contributor

No, the basic creating data source should test query simply. This PR is not completed for me. And I pulled your branch then executed the test case found the table orders is not found. Because the file path is wrong and you do not mount volume for the druid container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grieve54706 grieve54706 grieve54706 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
core dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation ibis python Pull requests that update Python code rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gagan-bhullar-tech @chilijung @grieve54706