Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(core): support to Array and Struct type #914

Merged
merged 5 commits into from
Nov 18, 2024
Merged

feat(core): support to Array and Struct type #914

merged 5 commits into from
Nov 18, 2024

Conversation

goldmedal
Copy link
Contributor

@goldmedal goldmedal commented Nov 18, 2024 •
edited
Loading

Description

Known Issue

The array of struct isn't supported now.

  • array<struct<number int>

@github-actions github-actions bot added core rust Pull requests that update Rust code labels Nov 18, 2024
@goldmedal goldmedal changed the title Support to Array and Struct type feat(core): support to Array and Struct type Nov 18, 2024
@github-actions github-actions bot added the python Pull requests that update Python code label Nov 18, 2024
@goldmedal goldmedal marked this pull request as ready for review November 18, 2024 05:24
@goldmedal goldmedal marked this pull request as draft November 18, 2024 05:28
@goldmedal goldmedal marked this pull request as ready for review November 18, 2024 06:10
grieve54706
grieve54706 approved these changes Nov 18, 2024
View reviewed changes
Copy link
Contributor

@grieve54706 grieve54706 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @goldmedal.

@grieve54706 grieve54706 merged commit 9bfffc1 into Canner:main Nov 18, 2024
13 checks passed
@goldmedal goldmedal deleted the feature/array-struct branch November 18, 2024 06:15
@goldmedal goldmedal mentioned this pull request Nov 18, 2024
Open
@grieve54706 grieve54706 added this to the 0.12.1 milestone Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grieve54706 grieve54706 grieve54706 approved these changes

Assignees
No one assigned
Labels
core python Pull requests that update Python code rust Pull requests that update Rust code
Projects
None yet
Milestone
0.12.1
Development

Successfully merging this pull request may close these issues.

Datafusion make ARRAY[] to make_array
2 participants
@goldmedal @grieve54706