test: create a framework for testing functions #922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
ibis
dependencies
grieve54706
force-pushed
the
test/all-functions-for-pg
branch
from
1bcfcb5
to
def0fb9
Compare
goldmedal
reviewed
Nov 19, 2024
| scalar,quote_ident,text,,text,"Quote identifier" | ||
| scalar,quote_literal,text,,any,"Quote literal" | ||
| scalar,quote_nullable,text,,any,"Quote nullable" | ||
| scalar,regexp_split_to_array,text[],,text&text,"Split string by pattern" |
There was a problem hiding this comment.
The array type should be defined like this
Suggested change
| scalar,regexp_split_to_array,text[],,text&text,"Split string by pattern" | |
| scalar,regexp_split_to_array,array<text>,,text&text,"Split string by pattern" |
Comment on lines
65
to
67
| # It will be failed because Rust can not read CSV correctly | ||
| # the_func = next(filter(lambda x: x["name"] == "extract", result)) | ||
| # assert the_func == { |
grieve54706
force-pushed
the
test/all-functions-for-pg
branch
from
def0fb9
to
966fe68
Compare
|
Hi @goldmedal, I adjusted the CSV and CSV reader based on the new Wren core. It looks so good. Thanks for your help. |
goldmedal
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test all functions in CSV could be executed.