test(bigquery): test all functions #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bigquery
ibis
python
grieve54706
force-pushed
the
test/all-functions-for-bq
branch
from
13a0674
to
276f882
Compare
grieve54706
commented
Nov 20, 2024
Comment on lines
+109
to
+111
| # Skip window functions util https://github.com/Canner/wren-engine/issues/924 is resolved | ||
| if function.function_type == "window": | ||
| continue |
Comment on lines
+112
to
+123
| # Skip functions with interval util https://github.com/Canner/wren-engine/issues/930 is resolved | ||
| if function.name in ( | ||
| "date_add", | ||
| "date_sub", | ||
| "date_diff", | ||
| "date_trunc", | ||
| "timestamp_add", | ||
| "timestamp_sub", | ||
| "timestamp_diff", | ||
| "timestamp_trunc", | ||
| ): | ||
| continue |
goldmedal
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust sql generator by dialect.
Add test case for bigquery.