feat(engine): handle target.* #933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @grieve54706. Could you add some test for the model with calculated fields and the SQL with a join statement? |
goldmedal
reviewed
Nov 21, 2024
Comment on lines
151
to
161
| def test_query_with_dot_all(manifest_str, postgres: PostgresContainer): | ||
| connection_info = _to_connection_info(postgres) | ||
| response = client.post( | ||
| url=f"{base_url}/query", | ||
| params={"limit": 1}, | ||
| json={ | ||
| "connectionInfo": connection_info, | ||
| "manifestStr": manifest_str, | ||
| "sql": 'SELECT "o".* FROM "Orders" AS "o"', | ||
| }, | ||
| ) |
There was a problem hiding this comment.
Could you add the end-to-end SQL test for the calculated field and join syntax? Maybe we should add tested in TestDynamicFields, too. We need to make sure the model-generating behavior is fine in WrenSqlRewrite.
goldmedal
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle the sql with dot all like
SELECT table.* FROM tableandSELECT t.* FROM table AS t.