forked from telia-oss/terraform-aws-ecs-fargate
-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wait for ECS service to stabilize #9
Draft
stekern
wants to merge
14
commits into
Cantara:master
Choose a base branch
from
nsbno:wait-for-stable-service
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add ulimits variable and block to container_definitions
…#2) * add local for container_definition that is then json encoded - this allows use of null
Co-authored-by: Henrik Gundersen <[email protected]>
colincoleman
force-pushed
the
master
branch
2 times, most recently
from
July 7, 2023 13:40
73ce250
to
dc462c0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first of these checks is built-in to the AWS provider >= 3.13.0 as a parameter
wait_for_steady_state
in theaws_ecs_service
resource, but a local provisioner can be used to support older provider versions. The target group check is not supported by the AWS provider.Any thoughts on this functionality?