Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the crate to use the latest version of the IGDB API #5

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

Hukadan
Copy link

@Hukadan Hukadan commented Dec 20, 2022

Hi,
I have updated this crate to use the latest version of the IGDB API. The main modifications are:

  • a client_id and a token are now needed to use the API
  • the surf crate seems to be unmaintained so I replaced it by the reqwest crate
  • the examples can be run by setting environment variables instead of modifying examples themselves
  • I have updated the dependencies (the async-std needs the tokio1 feature for the examples to run).

I have started to learn Rust not so long ago, so it might not be perfect.

Tests passes and examples work.

Thank you.

@Hukadan
Copy link
Author

Hukadan commented Jan 27, 2023

Hi,
Did you have time to look at my PR? If you are not interested in this crate anymore, do no hesitate to tell me and I will fork it instead.
Thank you for your time (and your code, from which I learned a lot).
Have a nice day.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant