adressing add pylint workflow and fix all issues #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djeck1432
requested changes
Oct 30, 2024
| - name: Set up Python | ||
| uses: actions/setup-python@v4 | ||
| with: | ||
| python-version: '3.10' |
| from .celery_conf import app | ||
|
|
||
| connector = DBConnector() | ||
|
|
||
|
|
||
| # @app.task(name="run_loan_states_computation_for_hashtack_v0") |
There was a problem hiding this comment.
please, don't remove any code
| from data_handler.handlers.liquidable_debt.protocols import ( | ||
| hashstack_v0, | ||
| hashstack_v1, | ||
| nostra_alpha, | ||
| nostra_mainnet, | ||
| zklend, | ||
| ) | ||
|
|
||
| # from data_handler.handlers.loan_states.hashtack_v0.run import HashtackV0StateComputation |
There was a problem hiding this comment.
please, leave these imports
|
|
||
|
|
||
| # @app.task(name="run_loan_states_computation_for_hashtack_v1") | ||
| # def run_loan_states_computation_for_hashtack_v1(): |
| @@ -86,26 +43,15 @@ def run_loan_states_computation_for_nostra_alpha(): | |||
| ) | |||
|
|
|||
|
|
|||
| # @app.task(name="run_loan_states_computation_for_nostra_mainnet") | |||
|
|
||
| __ | ||
|
|
||
|
|
There was a problem hiding this comment.
you have duplicated code
| @@ -114,8 +123,10 @@ class ProtocolAddresses: | |||
| NOSTRA_EVENTS_MAPPING = { | |||
| "Mint": "process_debt_mint_event", | |||
| "Burn": "process_debt_burn_event", | |||
| "nostra::core::tokenization::lib::nostra_token::NostraTokenComponent::Burn": "process_debt_burn_event", | |||
There was a problem hiding this comment.
why did you remove this code?
| @@ -27,29 +33,19 @@ | |||
|
|
|||
| # Source: https://docs.nostra.finance/lend/deployed-contracts/lend-alpha#asset-contracts. | |||
| NOSTRA_ALPHA_TOKEN_ADDRESSES: list[str] = [ | |||
| # '0x0061d892cccf43daf73407194da9f0ea6dbece950bb24c50be2356444313a707', # iWBTC | |||
There was a problem hiding this comment.
Don't remove any code, please!!!!
|
sorry for the inconvenience, im a complete newbie, i tried linting the codes using black, but that didnt entirely fix all the long line issues, so i did some manually and messed up a lot. |
|
|
@sigmadawg If you're having issues, I could help work on it and put up a PR in One hour, if that's okay with you. cc @djeck1432 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addresses #262