Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sf|h3): reimplement polyfill h3 functions #490

Conversation

DeanSherwin
Copy link
Contributor

Description

Shortcut

Re-implement the H3_POLYFILL functions to use the new native H3 functions on Snowflake

Type of change

  • Refactor

Acceptance

The H3_POLYFILL functions should produce the same output as on main branch.

@DeanSherwin DeanSherwin self-assigned this Mar 26, 2024
Copy link

@DeanSherwin DeanSherwin marked this pull request as draft March 26, 2024 09:57
@DeanSherwin DeanSherwin force-pushed the chore/sc-391761/implement-h3-polyfill-mode-table-in-at-snowflake branch from 969a699 to 840b2f0 Compare March 26, 2024 10:10
@DeanSherwin DeanSherwin changed the base branch from main to chore/sc-391760/reimplement-basic-h3-functions-in-at-snowflake March 26, 2024 10:11
@DeanSherwin DeanSherwin force-pushed the chore/sc-391761/implement-h3-polyfill-mode-table-in-at-snowflake branch 2 times, most recently from 09b6612 to 4a6a6a5 Compare March 26, 2024 13:28
@DeanSherwin DeanSherwin force-pushed the chore/sc-391760/reimplement-basic-h3-functions-in-at-snowflake branch from 0f8cc80 to 2c68f1b Compare March 27, 2024 08:44
@DeanSherwin DeanSherwin force-pushed the chore/sc-391761/implement-h3-polyfill-mode-table-in-at-snowflake branch from e66bda1 to b240d33 Compare March 27, 2024 11:15
@DeanSherwin DeanSherwin force-pushed the chore/sc-391760/reimplement-basic-h3-functions-in-at-snowflake branch from 6603c08 to b83c587 Compare March 27, 2024 17:35
@Jesus89 Jesus89 changed the base branch from chore/sc-391760/reimplement-basic-h3-functions-in-at-snowflake to main March 27, 2024 18:41
@DeanSherwin DeanSherwin force-pushed the chore/sc-391761/implement-h3-polyfill-mode-table-in-at-snowflake branch from 2a80c06 to acf41ef Compare March 31, 2024 13:52
@DeanSherwin DeanSherwin force-pushed the chore/sc-391761/implement-h3-polyfill-mode-table-in-at-snowflake branch from 84b1710 to 4a16532 Compare April 2, 2024 07:14
@DeanSherwin DeanSherwin force-pushed the chore/sc-391761/implement-h3-polyfill-mode-table-in-at-snowflake branch from b49eabc to 23f93ce Compare April 4, 2024 13:08
@DeanSherwin DeanSherwin marked this pull request as ready for review April 5, 2024 12:27
README.md Outdated Show resolved Hide resolved
Copy link
Member

@Jesus89 Jesus89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Good work dealing with Snowflake!

@DeanSherwin DeanSherwin force-pushed the chore/sc-391761/implement-h3-polyfill-mode-table-in-at-snowflake branch from 6010c2c to e24f836 Compare April 8, 2024 10:11
Copy link
Contributor

@vdelacruzb vdelacruzb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. LGTM!

@DeanSherwin DeanSherwin merged commit d51021b into main Apr 8, 2024
10 checks passed
@vdelacruzb vdelacruzb mentioned this pull request Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants