Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get ws url from config service #2

Merged
merged 1 commit into from
Apr 4, 2024
Merged

get ws url from config service #2

merged 1 commit into from
Apr 4, 2024

Conversation

jaonoctus
Copy link
Member

No description provided.

@jaonoctus jaonoctus force-pushed the fix/ws-url-from-config branch from 51bb01e to 967829e Compare April 3, 2024 23:37
nGoline
nGoline reviewed Apr 4, 2024
View reviewed changes
@jaonoctus jaonoctus force-pushed the fix/ws-url-from-config branch from 967829e to f063b64 Compare April 4, 2024 13:15
@jaonoctus jaonoctus requested a review from nGoline April 4, 2024 13:21
nGoline
nGoline approved these changes Apr 4, 2024
View reviewed changes
Copy link
Contributor

@nGoline nGoline left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jaonoctus jaonoctus merged commit faee6f8 into main Apr 4, 2024
@jaonoctus jaonoctus deleted the fix/ws-url-from-config branch April 4, 2024 20:01
@jaonoctus jaonoctus mentioned this pull request Apr 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nGoline nGoline nGoline approved these changes

@lorenzolfm lorenzolfm lorenzolfm approved these changes

@johnnyasantoss johnnyasantoss Awaiting requested review from johnnyasantoss

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jaonoctus @nGoline @lorenzolfm