Merge pull request #57 from CatLib/1.0

container add guard
CatLib · Sep 8, 2017 · 78c3d09 · 78c3d09
2 parents 44233a7 + 33837ca
commit 78c3d09
Show file tree

Hide file tree

Showing 2 changed files with 16 additions and 0 deletions.
diff --git a/projects/CatLib.API/Support/Container/Container.cs b/projects/CatLib.API/Support/Container/Container.cs
@@ -203,6 +203,11 @@ public IContainer Alias(string alias, string service)
             Guard.NotEmptyOrNull(alias, "alias");
             Guard.NotEmptyOrNull(service, "service");
 
+            if (alias == service)
+            {
+                throw new RuntimeException("Alias is Same as Service Name: [" + alias + "].");
+            }
+
             alias = Normalize(alias);
             service = Normalize(service);
 

diff --git a/projects/CatLib.Tests/Support/Container/ContainerTests.cs b/projects/CatLib.Tests/Support/Container/ContainerTests.cs
@@ -1265,6 +1265,17 @@ public void TestReleaseAllStaticService()
             Assert.AreEqual(null, container.Make("Test"));
         }
 
+        [TestMethod]
+        public void TestSameAliaseServiceName()
+        {
+            var container = MakeContainer();
+
+            ExceptionAssert.Throws<RuntimeException>(() =>
+            {
+                container.Singleton<ContainerTest>().Alias<ContainerTest>();
+            });
+        }
+
         public class TestParamsMakeClass
         {
             public TestParamsMakeClass()