Fix C runtime windows build #786
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vincent-botbol
force-pushed
the
vbot@fix-ar-c-runtime
branch
from
94a23f6 to
6c70220
Compare
AltGr
approved these changes
Feb 12, 2025
runtimes/c/discover.ml
Outdated
| build system handle it properly. *) | ||
| Config.c_compiler | ||
| |> replace_string (compile (str "gcc")) ~by:"ar" | ||
| |> print_string |
There was a problem hiding this comment.
Can it not happen (on mac ?) that this is cc or clang ? In this case this would call cc instead of ar ; maybe check if Config.c_compiler ends with gcc and then only replace, otherwise returning ar ?
There was a problem hiding this comment.
Oh you're absolutely right.
There was a problem hiding this comment.
I made sure that we were on windows and improved the regex a little. It seems to work as intended on both mac & windows.
There was a problem hiding this comment.
Windows automatically create ".exe"-less aliases for .exe binaries so it's safe to call it without the extension.
vincent-botbol
force-pushed
the
vbot@fix-ar-c-runtime
branch
3 times, most recently
from
59485a5 to
097d38d
Compare
vincent-botbol
force-pushed
the
vbot@fix-ar-c-runtime
branch
from
097d38d to
b7a75c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the build on windows which failed due to an invocation to
arwhich wasn't named this way on windows.It also fixes an issue introduced in #784 which made the failing build fails even more because windows's equivalent to pkg-config doesn't consider the cygwin folder.