Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ported matching API #1336

Merged
merged 1 commit into from
Jul 2, 2024
Merged

Ported matching API #1336

merged 1 commit into from
Jul 2, 2024

Conversation

djtfmartin
Copy link
Contributor

@djtfmartin djtfmartin commented Jun 27, 2024

Ported matching-ws API

This work is largely described in this issue: #1302

This is a ported version of some parts of the gbif/checklistbank code - the index generation parts and the name usage matching API.

A few points:

  • This module creates a standalone, Spring boot lucene-based search API. It is using Lucene 9.
  • There is an accompanying client module that uses Feign in the key-value-store module.
  • The module will support the generation of an single lucene index for a checklist. I can do this by connecting to ChecklistBank DB, or using a pre-generated CSV.
  • This is using Java 11, Spring 2 so it can fit in with the main backend build
  • The service is available to run as a executable Jar file.
  • The module includes a Dockerfile for creating a container to package the ws module and an index built from a dataset, the produced container will have the Lucene index.

Other issues tackled in this PR:

@djtfmartin djtfmartin changed the title Ported matching APi Ported matching API Jun 27, 2024
@djtfmartin djtfmartin force-pushed the matching-ws-pr branch 2 times, most recently from 1e09946 to a52d8a3 Compare June 28, 2024 07:49
@CatalogueOfLife CatalogueOfLife deleted a comment from gitguardian bot Jun 28, 2024
@CatalogueOfLife CatalogueOfLife deleted a comment from gitguardian bot Jun 28, 2024
Copy link

gitguardian bot commented Jun 28, 2024

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@djtfmartin djtfmartin force-pushed the matching-ws-pr branch 3 times, most recently from e528a20 to 6402363 Compare June 28, 2024 13:48
@djtfmartin djtfmartin marked this pull request as ready for review June 28, 2024 13:49
@djtfmartin djtfmartin force-pushed the matching-ws-pr branch 5 times, most recently from cdd6ea3 to 17eca37 Compare June 29, 2024 08:47
@djtfmartin djtfmartin merged commit 8ed8282 into master Jul 2, 2024
1 check passed
@djtfmartin djtfmartin deleted the matching-ws-pr branch August 8, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants