Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the new "quick earn" feature. Allows user to input how many po… #1281

Closed
wants to merge 1 commit into from

Conversation

HajinSuh21
Copy link

Adding the new "quick earn" feature. Allows user to input how many points they earned and updates current balance. Solved by creating a new button and adding functionality to the button based on other buttons. This feature was selected because it provided an easy way to see if the feature was added correctly or not.

…ints they earned and updates current balance. Solved by creating a new button and adding functionality to the button based on other buttons. This feature was selected because it provided an easy way to see if the feature was added correctly or not.
@HajinSuh21
Copy link
Author

Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

Signed-off-by: Hajin C Suh [email protected]

@TheLastProject
Copy link
Member

TheLastProject commented Apr 24, 2023

Thanks for your contribution. There's however a few issues with it:

  1. It modified a LOT of unrelated code, indenting changes all over the place, all in a single commit. In the current state, this is not reviewable.
  2. The unit tests no longer pass.
  3. The issue this is about, Quick earn #1167, is in state "consensus-needed" and contains several unanswered questions and an uncertainty if this is even a good idea to add. Meaningful discussion is needed before anything relevant to this feature can be implemented.

So, I'm sorry, but I cannot accept or even review this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants