Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/import export hacks #1983

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Fix/import export hacks #1983

merged 2 commits into from
Jul 7, 2024

Conversation

TheLastProject
Copy link
Member

Keeps screen on import/export activity to prevent getting killing in background (fixes #1978)
Also cancels import/export when tapping next to the progress dialog (fixes #1980)

@Korb I don't have a big enough export file to test either of these (the imports/exports finish way too fast for me). Could you please test this? I've attached a debug build (but feel free to build from this commit yourself too if you'd rather do that): app-debug.zip

@Korb
Copy link

Korb commented Jul 7, 2024

@TheLastProject, I tested importing and exporting a large collection of cards using your build.

✅ The import/export operation aborts without prompting when you tap on the screen outside of the import or export process notification.
✅ The screen does not turn off during import and export.
✅ The screen does not go blank when the import/export success notification is displayed on the screen.

OS version: Funtouch OS 14
Model: Vivo T1 4G (V2153)
Hardware version: MP_0.1
Build number: PD22010F_EX_A_14.2.7.12.W20
Baseband version: S.HA.1.1.c2-00054-DIVAR_GENSP_PACK-1.29062.88
Kernel version: 4.19.157-perf+, 1 Wed Jun 5 10:25:33 CST 2024
Compile time: 5 Jun 2024 05:20:41
Android security update: 1 June 2024

@TheLastProject
Copy link
Member Author

Thanks for confirming!

@TheLastProject TheLastProject merged commit 968729f into main Jul 7, 2024
1 check passed
@TheLastProject TheLastProject deleted the fix/importExportHacks branch July 7, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Handle click outside of import process notification Keep the screen on during export
2 participants