Allow to perform action inside search results dataTable #2631
Conversation
| <h:dataTable id="resultsTable" value="#{SearchIncludeFragment.searchResultsList}" var="result" | ||
| rendered="#{!(empty SearchIncludeFragment.searchResultsList)}"> | ||
| <h:dataTable id="resultsTable" value="#{lastSearchValue.searchResultsList}" var="result" | ||
| rendered="#{!(empty lastSearchValue.searchResultsList)}"> | ||
| <h:column> | ||
| <!--DATAVERSE CARDS--> | ||
| <div class="dataverseResult clearfix #{result.unpublishedState ? 'unpublished' : ''}" jsf:rendered="#{result.type eq searchObjectTypeEnum.DATAVERSES}"> | ||
| <c:set var="dvUrl" value="/dataverse/#{result.dataverseAlias}"/> | ||
| <c:set var="dvUrlFinal" value="#{!SearchIncludeFragment.rootDv and !result.isInTree ? dvUrl : widgetWrapper.wrapURL(dvUrl)}" /> |
There was a problem hiding this comment.
Shouldn't we use lastSearchValue here as well? Wonder if we couldn't have changed the scope of SearchIncludeFragment from @RequestScoped to @ViewScoped instead? Could imaging that someone could make use of SearchIncludeFragment bean in the future without being aware of the issue.
There was a problem hiding this comment.
At some point in time SearchIncludeFragment was @ViewScoped. We have changed it to @RequestScoped to reduce down memory consumption in the application. Search pages are the most common page visited by bots and it seemed a really wasteful approach to keep in memory so much copies of basically dead data. Each page render even by the same bot can create separate ViewScope. Also taking into account that ViewScope can live as long as session lives and our session are very long it adds up. So I didn't want move backwards to the place like it was before.
I've also perceive existence of session scoped lastSearchValue as a threat to high memory consumption. But this was been already introduced (to be able to download csv with search results) so I used it also for this case. I didn't came up with more elegant solution.
Maybe if the component was not <h:dataTable> but simple <ui:repeat> we could use request scope . I didn't check it.
There was a problem hiding this comment.
Oh forgot about the other thing, so using SearchIncludeFragment.rootDv instead of lastSearchValue.rootDv is not an error?
There was a problem hiding this comment.
Not sure why but it does not fail. I would expect to NPE be thrown. Either way I will change it to lastSearchValue.rootDv.
madryk
deleted the
feature/allow_for_button_action_inside_search_results
branch
The main reason for the changes are because we want to render some buttons that have some actions attached inside
pluggable/search-include-footer-fragment.xhtml. Thepluggable/search-include-footer-fragment.xhtmlis rendered insidef:dataTablecomponent.Currently when we click on the button then nothing happens. Reason behind this is that
SearchIncludeFragment(bean connected to thef:dataTable) is request scoped. When we click the buttonSearchIncludeFragmentwas already removed from jsf context. But to perform the action jsf need for this bean to be present.As a solution I've changed the bean that is connected to the
f:dataTabletolastSearchValuewhich has broader scope.Thread where the solution to the problem was found: https://stackoverflow.com/a/4128723