Closes #2638: Add application property that allows to switch whether files are required to publish dataset #2639
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e required to publish dataset
madryk
changed the title
rscipien
reviewed
Jan 29, 2025
| and DatasetPage.dataset.owner.released | ||
| and DatasetPage.canPublishDataset() | ||
| and DatasetPage.isLatestDatasetWithAnyFilesIncluded()}"> | ||
| rendered="#{DatasetPage.showPublishButtonCase() == 'PUBLISH_RELEASED'}"> |
There was a problem hiding this comment.
I see in some places usage of <o:importConstants type="edu.harvard.iq.dataverse.importers.ui.form.ItemType" var="ItemType"/>
Maybe we could replace string PUBLISH_RELEASED with enum like in java code?
There was a problem hiding this comment.
Yes. We can. I will update it.
There was a problem hiding this comment.
When I was applying changes I noticed that I mistaken PUBLISH_RELEASED and PUBLISH_NOT_RELEASED cases. That's why I swap them.
The naming for modals are a little confusing:
publishConfirm - is dedicated for datasets that was never published
releaseDraft - is dedicated for datasets that has some published version and we want to publish the draft as next version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#2638