-
Notifications
You must be signed in to change notification settings - Fork 67
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Measure rwc per object #256
base: master
Are you sure you want to change the base?
Conversation
Now, I have to create the for loop function. I deleted of commented all parts having to do with other measurements (including per image measurements) and also removed if statements, assuming here wants_obects is always True and perform_RWC is always True
if len(self.objects_list.value) == 0: | ||
raise ValidationError("No object sets selected", self.objects_list) | ||
|
||
def upgrade_settings(self, setting_values, variable_revision_number, module_name): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need this for this plugin (yet)
M_PER_OBJECT = "Within each object individually" | ||
|
||
"""Feature name format for the RWC Coefficient measurement""" | ||
F_RWC_FORMAT = "Correlation_RWC_%s_%s" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may cause a collision if the person has also measured RWC regularly, can we name it something different?
return True | ||
|
||
|
||
def get_scale(scale_1, scale_2): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
################################# | ||
|
||
import centrosome.cpmorphology | ||
import centrosome.zernike |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sure to remove the ones you don't. need
@@ -0,0 +1,28 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you remove this file from the commit, please?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome job! Just some cleanup to do, plus add to the documentation
No description provided.