Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand upper dependency boundaries #126

Closed
wants to merge 0 commits into from
Closed

Conversation

afermg
Copy link
Contributor

@afermg afermg commented Dec 6, 2024

Following #125, I first merged #123 and then created a reproducible environment using build. The additional changes I made are:

  • added nix/centrosome.nix with a nix package that builds centrosome (currently from my fork, so we should point to this repo before merging).
  • Added flake.nix, which just provides a reproducible environment for centrosome.nix to be installed

finally, run pytest, all tests passed (2 skipped). Logs here.
log.txt

We may still want to fix the upper boundaries, just to the maximum that is possible today. Let me know if that is the case or if we should leave them as-is.

@afermg
Copy link
Contributor Author

afermg commented Dec 12, 2024

@gnodar01 🐶

@gnodar01 gnodar01 self-requested a review December 13, 2024 16:19
@gnodar01 gnodar01 mentioned this pull request Dec 13, 2024
setup.py Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
@afermg
Copy link
Contributor Author

afermg commented Dec 13, 2024

  • Reverted the BuildExtension addition. That came from the PR I piggybacked, now it's not there.
  • Limited dependencies too be lower than the next major version (except for skimage, which is lower or equal than the current one because they are in 0.24).

Ran tests again and they run fine.
LMK if there is something else I should adjust.

@afermg afermg changed the title Remove upper boundaries Increase upper boundaries Dec 13, 2024
@afermg
Copy link
Contributor Author

afermg commented Dec 13, 2024

I updated the commit and hash of the flake too

@afermg afermg changed the title Increase upper boundaries Expand upper dependency boundaries Dec 13, 2024
@gnodar01 gnodar01 self-requested a review December 13, 2024 21:52
Copy link
Contributor

@gnodar01 gnodar01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All tests pass in CP5. Thanks!

@gnodar01
Copy link
Contributor

Whoops, did some merge conflicts and accidentally nuked everything. Replacing with #127.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants