Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Correct mistake in ZPL sensor configs #64

Merged
merged 5 commits into from
Jan 5, 2025
Merged

Conversation

Cellivar
Copy link
Owner

@Cellivar Cellivar commented Jan 5, 2025

Apparently my testing of ZPL sensor levels wasn't thorough enough, I needed to do more digging into various eras of manuals to sort out what was going wrong with setting some printer's values. This was only an issue if you were specifically setting sensors manually.

I dragged a bunch of different information into the docs for this one because I had to re-learn some of these pieces for the third time.

This also fixed a couple of issues with the demo UI.

@Cellivar Cellivar enabled auto-merge (squash) January 5, 2025 15:29
Copy link

github-actions bot commented Jan 5, 2025

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 61.61% 2868 / 4655
🔵 Statements 61.61% 2868 / 4655
🔵 Functions 49.1% 193 / 393
🔵 Branches 75.32% 522 / 693
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/Languages/Zpl/CmdHostConfig.ts 96.19% 93.27% 83.33% 96.19% 55-56, 59-61, 66-67, 223-225
src/Languages/Zpl/CmdSetSensorCalibration.ts 10.44% 50% 33.33% 10.44% 7-48, 56-77
src/Languages/Zpl/CmdXmlQuery.ts 89.11% 44.04% 95% 89.11% 57-61, 79-82, 85-89, 95-99, 104-105, 107-108, 139-143, 218, 220, 245, 332
src/Languages/Zpl/Config.ts 2.04% 0% 0% 2.04% 45-156
Generated in workflow #156 for commit c1bd958 by the Vitest Coverage Report Action

@Cellivar Cellivar merged commit 2c4f5ab into main Jan 5, 2025
1 check passed
@Cellivar Cellivar deleted the feature/fix-config-bug branch January 5, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant