This repository has been archived by the owner on May 24, 2024. It is now read-only.
docs: Remove workarounds from example.ks #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cgwalters Thoughts? |
|
I was thinking we'd merge this after an Anaconda ISO was generated; looks like |
cgwalters
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Confimed this works, thanks.
However I discovered a non-blocking followup issue to address rhinstaller/anaconda#5363
cgwalters
reviewed
Dec 6, 2023
|
Gah, the trailing whitespace check is annoying |
:-) It is.
|
The installer supports bootupd now, so we can drop the workaround. See: rhinstaller/anaconda#5298
The partitioning defined in the example kickstart file suggests that the installer supports hybrid boot. That's misleading and not true. Let's use the `reqpart` kickstart command to automatically create partitions required by the detected platform instead of creating all of them for all platforms. Note: The `reqpart` command doesn't work with `bootloader --location=none` or `bootloader --disabled`, so this commit depends on the installer's support for bootupd: rhinstaller/anaconda#5298
The kickstart file works with a Fedora 40+ (or ELN) installer ISO as it requires rhinstaller/anaconda#5342. Co-authored-by: Colin Walters <[email protected]>
poncovka
force-pushed
the
main-reqpart
branch
from
5b01c31
to
4886760
Compare
|
Updated. I run locally |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The partitioning defined in the example kickstart file suggests that the
installer supports hybrid boot. That's misleading and not true. Let's use
the
reqpartkickstart command to automatically create partitions requiredby the detected platform instead of creating all of them for all platforms.
Note: The
reqpartcommand doesn't work withbootloader --location=noneorbootloader --disabled, so this change depends on the installer's supportfor bootupd.
Depends on: rhinstaller/anaconda#5298