Skip kubelet call to update container resource while there is an async update in progress in libvirt #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…c update in progress in libvirt
XiaoningDing
approved these changes
Aug 31, 2020
…uest from kubelet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this PR
skip repeated calls from kubelet while an async resource update is in progress for a given container.
Why is it needed
given a case where plug/unplug and repeat cases. runtime could end up in unknown stage
Special not to CR
A few changes in this PR at high level. currently they are restraint to be a "bugfix" level of code change for 830
Testing done
Add hoc patching tests