Send networkpolicy data from operator to daemon #338
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hong-Chang
commented
Dec 30, 2020
| def update_networkpolicy_per_endpoint(self, data): | ||
| if len(data["old"]) > 0: | ||
| self.delete_network_policy_ingress("no_except", data["old"]["ingress"]["cidr_table_no_except"]) | ||
| self.delete_network_policy_ingress("with_except", data["old"]["ingress"]["cidr_table_with_except"]) |
There was a problem hiding this comment.
Cathy, let's discuss how we will combine these into batch. And shall we combine delete and update into batch.
clu2xlu
suggested changes
Dec 31, 2020
| @@ -364,3 +375,109 @@ def update_agent_substrate(self, ep, bouncer): | |||
|
|
|||
| def delete_agent_substrate(self, ep, bouncer): | |||
| self.rpc.delete_agent_substrate_ep(ep, bouncer.ip) | |||
|
|
|||
| def update_networkpolicy_per_endpoint(self, data): | |||
There was a problem hiding this comment.
Any reason you dont want include this in mizar/obj/networkpolicy.py?
There was a problem hiding this comment.
To calculate bitmap value for network policies, there is quantity limitation for policy. So we decided to limit data scope to be within an endpoint. There could be 1000 policies in a cluster, but we expect less than 100 policies for a certain endpoint.
This function is to handle data for an endpoint. That's the reason putting the func here.
|
Approving for now to unblock the engineer. But we need revisit this and tracking this with issue #344 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.