[SVCS-528] Improve gdoc rendering - MFR Part #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 5, 2017
cslzchen
commented
Dec 5, 2017
mfr/server/handlers/core.py
Outdated
| @@ -104,6 +104,8 @@ def NAME(self): | |||
|
|
|||
| try: | |||
| self.url = self.request.query_arguments['url'][0].decode('utf-8') | |||
| # TODO should probably use furl here, but maybe wait till after furl is upgraded | |||
| self.url += '&mfr=true' | |||
There was a problem hiding this comment.
Need to use furl or UrlLib.
cslzchen
force-pushed
the
feature/svcs-528-improve-gdoc
branch
from
9d9ccec
to
5a88dd5
Compare
cslzchen
changed the title
cslzchen
changed the title
cslzchen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
https://openscience.atlassian.net/browse/SVCS-528
WB counterpart: CenterForOpenScience/waterbutler#304
Purpose
This PR replaces #292. Credit goes to @AddisonSchiller 🎆 🎆 .
.gdoc, MFR will receive a.pdffrom WB and render this file usingpdfrenderer.Changes
mfrquery param to WB urls to let it know the request is coming from MFR..gdocextension fromunoconvrenderer/exporter topdfrendererSide effects
None
QA Notes
Test that
.gdocrendering works as usual.Deployment Notes
This PR must be merged/deployed at the same time as its WB counterpart.
Same to the WB PR, this is blocked by @TomBaxter 's V3 update: CenterForOpenScience/waterbutler#276.